Skip non-relevant webhook events #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdimitrov
previously approved these changes
Oct 25, 2023
This patch makes mediator more strict when it comes to mapping webhook events, as not all events should trigger entity evaluation. Previously, we have been using repo evaluation as sort of a fallback, but in busy repositories with many PRs and issues, this could cause mediator to just spin all the time. Fixes: #1267
|
rebased. I removed the very recently added |
rdimitrov
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes mediator more strict when it comes to mapping webhook
events, as not all events should trigger entity evaluation. Previously,
we have been using repo evaluation as sort of a fallback, but in busy
repositories with many PRs and issues, this could cause mediator to just
spin all the time.
Fixes: #1267