Fixes to the OSV rule_type and profile #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdimitrov
reviewed
Nov 2, 2023
There was a problem hiding this comment.
Nice! 😃
Can you update the example in the doc too - https://github.com/stacklok/minder/blob/main/docs/docs/understand/profiles.md
- the rule type was missing the `sum_repository`. Luckily the rule still works fine if it defined extra attributes, but we should declare all we use in the schema. - the example profile was using https://vuln.go.dev which is wrong as it doesn't directly expose the OSV endpoint (just an edpoint with a compressed file in the right format)
sure, thank you for the quick review. |
evankanderson
approved these changes
Nov 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that writing docs finds issues.
sum_repository. Luckily the rule still works fine if it defined extra attributes, but we should declare all we use in the schema.