Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part 2 - The rest of the minder renaming #1457

Merged
merged 6 commits into from
Nov 4, 2023
Merged

Part 2 - The rest of the minder renaming #1457

merged 6 commits into from
Nov 4, 2023

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Nov 4, 2023 •
edited
Loading

This is the last part of the renaming:

  • Updates code from mediator to minder
  • Updates viper and other env vars from MEDIATOR_ to MINDER_ prefixed (will affect current use, if any)
  • Updated the metrics server name (I guess this implies changes on the dashboards too?)
  • Updated helm charts
  • Updated docs
  • Updated the mediator-server to minder-server image

Need 2nd opinion:

  • Removed the legacy mediator proto* (I was unsure if we need/want to keep the legacy mediator proto, decided to remove it but if this was a mistake, I can revert the commit)
  • Touched a comment and the initial root org in the 1st db schema. I assumed this is okay If we are going to wipe everything in favour of starting from scratch. If not, I'll revert it.

@rdimitrov
Rename mediator to minder
aeee3d4 
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov
Rename env vars from MEDIATOR to MINDER
505cd0a 
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov
Rename docs, comments and vars usage to Minder
df3c717 
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov
Rename Minder in proto/buf.yaml
1b60808 
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov
Delete legacy proto/mediator
da1abe2 
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov
Small capitalisation fixes for Minder
eed6829 
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov self-assigned this Nov 4, 2023
@JAORMX
Copy link
Contributor

JAORMX commented Nov 4, 2023

I can force merge this of needed

@JAORMX JAORMX merged commit 3a8fcf1 into stacklok:main Nov 4, 2023
13 of 14 checks passed
@JAORMX JAORMX deleted the rename branch November 4, 2023 07:00
@evankanderson evankanderson mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX JAORMX approved these changes

Assignees

@rdimitrov rdimitrov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdimitrov @JAORMX