Pass the staging/prod build tag through a Makefile env variable #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
reviewed
Nov 4, 2023
jhrozek
force-pushed
the
staging_again
branch
from
9513228
to
38ce6b8
Compare
good idea! |
JAORMX
approved these changes
Nov 4, 2023
|
Let's change the description of this PR. Otherwise I like this. Binaries built from source using our makefile will point to staging, and releases will point to production. |
rdimitrov
reviewed
Nov 4, 2023
There was a problem hiding this comment.
Should we update goreleaser too to the prod tag?
Let's open a PR to do that, but before merging the PR, let's check with @evankanderson on prod status - I assume that the released binaries would be used already by people working on the docs this weekend and on Monday and I wouldn't like to interrupt their flow with binaries that point to env that can't be used.
jhrozek
changed the title
jhrozek
changed the title
JAORMX
approved these changes
Nov 4, 2023
|
Prod is up and running. This is good to go |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a a Makefile variable that sets the staging or prod env tag. Currently the variable defaults to staging, we'll switch it to prod when ready.