Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reading secrets from file for GH App config #3040

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

eleftherias
Copy link
Member

Summary

In our deployment we need to read the fallback token and webhook secret from files.

Fixes #3039
Fixes #3038

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner April 11, 2024 08:13
@coveralls
Copy link

Coverage Status

coverage: 48.216% (-0.004%) from 48.22%
when pulling 15d754b on eleftherias:gh-config-from-file
into 471f6de on stacklok:main.

@eleftherias eleftherias merged commit acec132 into stacklok:main Apr 11, 2024
21 checks passed
@eleftherias eleftherias deleted the gh-config-from-file branch April 11, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants