Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust getting started documentation #897

Merged

Conversation

eleftherias
Copy link
Member

Some suggestions for improving the getting started documentation.

Copy link
Member

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@@ -210,7 +210,7 @@ First, you'll need to enroll your first provider. Before doing this, make sure t
and fill in the appropriate settings in your `config.yaml` file.

You may create an OAuth2 application [here](https://github.com/settings/developers). Select
`New OAuth App` and fill in the details. The callback URL should be `http://localhost:8080/api/v1/auth/callback/github/cli`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I now realised I forgot to flag that too when I encountered it myself 😃

@eleftherias eleftherias merged commit 11bc16c into stacklok:main Sep 8, 2023
2 checks passed
@eleftherias eleftherias deleted the getting-started-improvements branch September 8, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants