fix: resolve tag conflicts for versioned artifacts #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
JAORMX
reviewed
Sep 11, 2023
|
Your patch looks good overall. Just added some "nits". Feel free to take them or continue as-is if you want. |
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Thanks, I've just addressed your feedback 👍 |
JAORMX
approved these changes
Sep 11, 2023
jhrozek
reviewed
Sep 11, 2023
jhrozek
reviewed
Sep 11, 2023
jhrozek
reviewed
Sep 11, 2023
jhrozek
reviewed
Sep 11, 2023
JAORMX
previously approved these changes
Sep 11, 2023
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
|
@jhrozek - addressed your feedback, so feel free to re-review 👍 |
JAORMX
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On each publish event for a package/artifact we insert a new record in artifact_versions which has a given set of tags associated with it. After a while we end up having multiple records that share the same tag entries (or one is a subset of the other) which is wrong given that a tag should be matched to only one image digest.
The following PR introduces the idea of searching for all existing entries that match the incoming tag value in their Tags field. If found, the existing artifact is updated by removing the incoming tag from its tags column.
Fixes #814