-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: race condition for signed versioned artifacts #932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't ack this patch because we wrote it in a pairing session with Rado, so someone else should click the review button
fb78ce0
to
777a271
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way we could add a test for this?
yes, we should add a test in general for the artifact webhook like we have for the repo webhook. Note that this might involve mocking the APIs to get the signatures which currently call out to rekor. |
I'll give it a go 👍 |
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
777a271
to
0b7e043
Compare
The following PR fixes a race condition happening depending on the order of receiving events for signed versioned artifacts. The result was a never ending loop trying to process the artifact publish event.
Marking as draft since it was created during debugging with Jakub. It will be converted once we agree on the solution.