fix: race condition for signed versioned artifacts #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdimitrov
added
bug
jhrozek
reviewed
Sep 12, 2023
jhrozek
reviewed
Sep 12, 2023
rdimitrov
force-pushed
the
race-condition
branch
from
fb78ce0
to
777a271
Compare
JAORMX
reviewed
Sep 12, 2023
|
yes, we should add a test in general for the artifact webhook like we have for the repo webhook. Note that this might involve mocking the APIs to get the signatures which currently call out to rekor. |
|
I'll give it a go 👍 |
JAORMX
previously approved these changes
Sep 12, 2023
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
rdimitrov
force-pushed
the
race-condition
branch
from
777a271
to
0b7e043
Compare
JAORMX
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR fixes a race condition happening depending on the order of receiving events for signed versioned artifacts. The result was a never ending loop trying to process the artifact publish event.
Marking as draft since it was created during debugging with Jakub. It will be converted once we agree on the solution.