vulndb evaluator: Cleanups and unit tests for the package database lookups #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
requested changes
Sep 13, 2023
…egistry
The fixes include:
- properly handle non-200 error codes
- get rid of the separate npmPackageReply and packageJson
structures, just parse what we need using a single struct
- don't read the whole reply into a byte slice, use a reader instead
This will make the http queries more performant
Increases test coverage from 0% to ~90% for the pkgdb.go module
jhrozek
force-pushed
the
pkg-json-refactor-tests
branch
from
7211663
to
f9abbc4
Compare
JAORMX
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR to implement the first version of PR vulnerability scanning was merged
so that we can have something demoable soon, but the code quality was not up
to even MVP standards (thanks Ozz and Luke for closing both eyes during review).
As I'm implementing the rest of the features for this epic, I'm also going
back and cleaning up the code and adding tests. This PR handles the package
database module.
Commit messages in the patches have more details about each patch.