Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vanilla Falco #1343

Merged
merged 22 commits into from
Jan 5, 2024
Merged

Use vanilla Falco #1343

merged 22 commits into from
Jan 5, 2024

Conversation

Molter73
Copy link
Collaborator

Description

This change makes it so collector compiles and runs using upstream Falco directly. There are a few minor tweaks still required in Falco itself, but they are things that are either on their way to upstream or should be real ease to upstream.

List of changes needed for vanilla to be compatible:

  • Remove sinsp-wrapper and link directly to sinsp.
  • Remove sinsp_filter_check_iface in favor of sinsp_filter_check.
  • Use MINIMAL_BUILD instead of MINIMAL_BUILD_WITH_EBPF.
  • Remove g_bpf_drop_syscalls.
  • eBPF probe is compiled directly instead of via cmake.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Molter73 Molter73 added the integration-tests-trace-logging Turn on additional logging in Collector label Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023 •
edited
Loading

Kernel Method Without Collector Time (secs) With Collector Time (secs) Baseline median (secs) Collector median (secs) PValue

@Molter73 Molter73 force-pushed the mauro/use-falco-upstream branch 6 times, most recently from ff480e3 to 88e1c15 Compare October 11, 2023 07:53
@Molter73 Molter73 added run-multiarch-builds Run steps for non-x86 archs. and removed skip-multiarch-builds labels Oct 19, 2023
@Molter73 Molter73 force-pushed the mauro/use-falco-upstream branch 3 times, most recently from b6837ad to 2700d87 Compare October 25, 2023 11:25
@Molter73 Molter73 mentioned this pull request Oct 25, 2023
Open
@Molter73 Molter73 mentioned this pull request Nov 9, 2023
Closed
11 tasks
Molter73 and others added 4 commits January 3, 2024 08:33
@Molter73 @Stringy
Build builder image
d77321f 
Needed to include the arm64 builder image
@erthalion @Stringy
Explicitly add procexit event
5161388 
One side effect of [1] is that procexit is not included by default
any more if ppm_sc is not empty. Which means to continue receiving
procexit we need to explicitly add it into the list of interesting
events. procexit is essential for memory management, as its handlers
perform threadinfo cache clean up.

[1]: falcosecurity/libs#1001
@erthalion @Stringy
Assert logging
4a445d8 
Turn on Falco assert logging for all build types. Make _DEBUG dependent
on the Debug build type, it would impact asserts logic when asserts
logging is disabled.
@erthalion @Stringy
Fix exit code in the debug mode
08f1f2e 
If CMAKE_BUILD_TYPE is debug, the condition for stripping the binary is
not invoked, and the resulting exit code is 1, stopping the build.
Ignore this branch and return exit code 0.
@Stringy
Native s390x builds and multi-arch testing (#1448)
16fa1e4 
- s390x images are now built natively
- ppc64le core-bpf is enabled
- VM creation is consolidated in GHA
- numerous improvements to ansible variables and multiarch VM creation
Stringy
Stringy reviewed Jan 3, 2024
View reviewed changes
Makefile-constants.mk Outdated Show resolved Hide resolved
@Stringy Stringy marked this pull request as ready for review January 3, 2024 14:14
@Stringy Stringy requested a review from a team as a code owner January 3, 2024 14:14
ovalenti
ovalenti reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@ovalenti ovalenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks good to me. Some parts are so much simpler 👍

ansible/group_vars/all.yml Outdated Show resolved Hide resolved
.github/workflows/integration-tests.yml Show resolved Hide resolved
ansible/roles/run-test-target/tasks/main.yml Outdated Show resolved Hide resolved
@Stringy Stringy merged commit b2a9788 into master Jan 5, 2024
85 of 90 checks passed
@Stringy Stringy deleted the mauro/use-falco-upstream branch January 5, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovalenti ovalenti ovalenti left review comments

@Stringy Stringy Stringy approved these changes

Assignees
No one assigned
Labels
all-integration-tests build-full-images build-legacy-probes integration-tests-trace-logging Turn on additional logging in Collector run-multiarch-builds Run steps for non-x86 archs. skip-built-drivers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Molter73 @Stringy @ovalenti @erthalion