-
Notifications
You must be signed in to change notification settings - Fork 1
Separate periodicals and PRs #227
Separate periodicals and PRs #227
Conversation
a43faa6
to
c70ec49
Compare
Regular jobs should not clash with development PRs, use staging buckets for that and add unique id to the VM name.
Stack staging and prod buckets for PRs, to pick up both, but write only to the first one.
c70ec49
to
ef6344c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
echo "KERNEL_PACKAGE_STAGING_BUCKET=${KERNEL_PACKAGE_STAGING_BUCKET}" | ||
# Scripts may read from all buckets but only write to the *first bucket* in the list. | ||
|
||
KERNEL_PACKAGE_BUCKET="gs://stackrox-kernel-packages-staging/copy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little weird that the copy/
subdirectory is the staging area for the main builds, but alright.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: erthalion, JoukoVirtanen, Molter73 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Regular jobs should not clash with development PRs, use staging buckets
for that and add unique id to the VM name.