This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Separate periodicals and PRs #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erthalion
force-pushed
the
ddolgov-feature-separate-envs-for-periodicals-and-prs
branch
2 times, most recently
from
a43faa6
to
c70ec49
Compare
Regular jobs should not clash with development PRs, use staging buckets for that and add unique id to the VM name.
Stack staging and prod buckets for PRs, to pick up both, but write only to the first one.
erthalion
force-pushed
the
ddolgov-feature-separate-envs-for-periodicals-and-prs
branch
from
c70ec49
to
ef6344c
Compare
Molter73
approved these changes
Oct 21, 2022
| echo "KERNEL_PACKAGE_STAGING_BUCKET=${KERNEL_PACKAGE_STAGING_BUCKET}" | ||
| # Scripts may read from all buckets but only write to the *first bucket* in the list. | ||
|
|
||
| KERNEL_PACKAGE_BUCKET="gs://stackrox-kernel-packages-staging/copy" |
There was a problem hiding this comment.
It's a little weird that the copy/ subdirectory is the staging area for the main builds, but alright.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: erthalion, JoukoVirtanen, Molter73 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
erthalion
deleted the
ddolgov-feature-separate-envs-for-periodicals-and-prs
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular jobs should not clash with development PRs, use staging buckets
for that and add unique id to the VM name.