Allow ignoring specific labels in dangling service selector check #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
reviewed
Dec 15, 2022
| for _, ignoredLabel := range p.IgnoredLabels { | ||
| delete(selector, ignoredLabel) | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you add a test for this change?
heckler1
force-pushed
the
sheckler/dangling-selector-params
branch
from
625fce1
to
68ebebe
Compare
janisz
approved these changes
Jan 2, 2023
dhaus67
approved these changes
Jan 3, 2023
abrad3
pushed a commit
to abrad3/kube-linter
that referenced
this pull request
Sep 28, 2023
…ackrox#465) Co-authored-by: Stephen Heckler <sheckler@cloudflare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have services that select pods based on
statefulset.kubernetes.io/pod-name, which is populated by the Kubernetes control plane. I would like to prevent this from being linted on for our use-case, while still checking if the other selector labels are correct.This instance with service labels is specific to my use-case, but I'm also happy to expand this to the other "dangling" checks if desired.