Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROX-11952] : Add new endpoint for NodeVulnerability csv export #2588

Conversation

charmik-redhat
Copy link
Contributor

@charmik-redhat charmik-redhat commented Aug 2, 2022

Description

  • Added new route for NodeCVE csv export.
  • Added new handler
  • Refactored code

Checklist

  • Investigated and inspected CI test results
  • [ ] Unit test and regression tests added
  • [ ] Evaluated and added CHANGELOG entry if required
  • [ ] Determined and documented upgrade steps
  • [ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Manual testing to check if old and new resolvers work correctly

@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@charmik-redhat
Copy link
Contributor Author

/test all

@roxbot
Copy link
Contributor

roxbot commented Aug 2, 2022

Images are ready for the commit at d7a644d.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.71.x-215-gd7a644d59b.

@charmik-redhat charmik-redhat marked this pull request as ready for review August 2, 2022 20:11
@charmik-redhat charmik-redhat changed the title Rox 10970/charmik/split CVE csv workflow and use new resolvers [ROX-11952] : Add new endpoint for NodeVulnerability csv export Aug 2, 2022
@charmik-redhat charmik-redhat force-pushed the ROX-10970/charmik/split-cve-csv-workflow-and-use-new-resolvers branch from 6a7c083 to affc233 Compare August 2, 2022 21:23
central/main.go Outdated Show resolved Hide resolved
@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2022

@charmik-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-nongroovy-e2e-tests d7a644d link false /test gke-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@charmik-redhat charmik-redhat merged commit c3f838f into master Aug 4, 2022
@charmik-redhat charmik-redhat deleted the ROX-10970/charmik/split-cve-csv-workflow-and-use-new-resolvers branch August 4, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants