Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed shellcheck lint for get-lb-ip.sh #3554

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

dastgirp
Copy link
Contributor

Description

Shell checks were ignored for file: k8s/get-lb-ip.sh file, this PR fixes the warnings provided by shellcheck (#3544)

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

executed command "make shell-style"

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2022

Hi @dastgirp. Thanks for your PR.

I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the external-contributor To put on issues and PRs from external contributors label Oct 25, 2022
@gavin-stackrox
Copy link
Contributor

/ok-to-test
/lgtm

Copy link
Contributor

@gavin-stackrox gavin-stackrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roxbot
Copy link
Contributor

roxbot commented Oct 25, 2022

Images are ready for the commit at 80cfe50.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-400-g80cfe50458.

@janisz janisz merged commit 610f36b into stackrox:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor To put on issues and PRs from external contributors ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants