Fix: Shell scripts to pass shellcheck linter for sensor.sh and central.sh

[rachana-dani]

Description

---

Fix shell scripts to pass Shellcheck linter for
deploy/k8s/sensor.sh
deploy/k8s/central.sh
deploy/openshift/central.sh

Checklist

• Investigated and inspected CI test results
• Unit test and regression tests added [Does not apply]
• Evaluated and added CHANGELOG entry if required [Does not apply]
• Determined and documented upgrade steps [Does not apply]
• Documented user facing changes (create PR based on [openshift/openshift-docs] Does not apply and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

CI pipeline is a sufficient indicator but tested by running make shell-style. It passed successfully.

[openshift-ci]

Hi @rachana-dani. Thanks for your PR.

I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[janisz]

/ok-to-test

[roxbot]

Images are ready for the commit at 4777193.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-436-g477719336f.

[janisz]

@rachana-dani Style check still failing

[janisz]

Where do we need this?

[rachana-dani]

Its needed for ROX_ADMIN_PASSWORD="$(cat ${K8S_DIR}/central-deploy/password)". I will move the suppress comment to appropriate position.

[rachana-dani]

@rachana-dani: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/grouped-static-checks d46ee71 link true /test grouped-static-checks
Full PR test history. Your PR dashboard.

Hey @janisz, I have excluded the file names from stylecheck_skip.txt and the grouped_static_checks are failing. This check is to see if files present in stylecheck_skip.txt don't have linting issues anymore. If none of the other tests are failing , why is this one failing?
Am I missing something? Can you please help me with this?

[rachana-dani]

@rachana-dani: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/grouped-static-checks 2202929 link true /test grouped-static-checks
Full PR test history. Your PR dashboard.

link

Hey @janisz , I have not made any changes to deploy/openshift/sensor.sh but yet somehow grouped_static_checks test is failing for me.
Please confirm if this is an issue? I don't think this is an expected behaviour?

[janisz]

/retest

[janisz]

Please remove deploy/openshift/sensor.sh from the list as it's symlink to k8s/sensor.sh

deploy/openshift/sensor.sh -> ../k8s/sensor.sh

[rachana-dani]

Thanks @janisz. @gavin-stackrox @tommartensen, can you please review this PR?

[gavin-stackrox]

Thanks @janisz. @gavin-stackrox @tommartensen, can you please review this PR?

Hi @rachana-dani, thanks for the fix! It looks like @janisz has approved the PR and a single approver is sufficient to merge. Are you able to merge it?