Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pgx and pgxpool v5 #4676

Closed
wants to merge 1 commit into from
Closed

Upgrade to pgx and pgxpool v5 #4676

wants to merge 1 commit into from

Conversation

connorgorman
Copy link
Collaborator

Description

Pick up the latest changes to the pgx library

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

CI

@roxbot
Copy link
Contributor

roxbot commented Feb 2, 2023

Images are ready for the commit at 141cda2.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.73.x-649-g141cda2d76.

@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2023

@connorgorman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/go-postgres-tests 141cda2 link true /test go-postgres-tests
ci/prow/gke-postgres-upgrade-tests 141cda2 link false /test gke-postgres-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@md2119
Copy link
Contributor

md2119 commented Feb 2, 2023

I literally did it in one of my PRs because I need this for my search framework enhancements.

@md2119
Copy link
Contributor

md2119 commented Feb 7, 2023

Do we want to upgrade v5 now? Seems like the performance of v5 are inferior to v4. Ref: jackc/pgx#1481

@connorgorman
Copy link
Collaborator Author

@md2119

Do we want to upgrade v5 now? Seems like the performance of v5 are inferior to v4. Ref: https://github.com/jackc/pgx/issues/1481

This was on a windows machine. There is an issue resolving arrays which we need to fix. Haven't figured it out yet

@connorgorman
Copy link
Collaborator Author

I'm also tempted to just hide this underneath a struct so it's not a 405 line change

@janisz
Copy link
Contributor

janisz commented Jul 13, 2023

@janisz janisz mentioned this pull request Jul 13, 2023
5 tasks
@janisz janisz mentioned this pull request Nov 6, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants