-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-18155: pg generic store: GetByQuery #6771
ROX-18155: pg generic store: GetByQuery #6771
Conversation
Images are ready for the commit at fb1f5d0. To use with deploy scripts, first |
0eaac20
to
8228546
Compare
2975cf0
to
48788ec
Compare
8228546
to
3a85339
Compare
48788ec
to
8ff2fcb
Compare
3a85339
to
b49fbe0
Compare
8ff2fcb
to
2a14858
Compare
b49fbe0
to
54040b8
Compare
2a14858
to
387ba5f
Compare
54040b8
to
824a8e5
Compare
387ba5f
to
6fb7695
Compare
824a8e5
to
737eed5
Compare
6fb7695
to
2db5911
Compare
737eed5
to
f8ee78b
Compare
2db5911
to
ba81a0e
Compare
f8ee78b
to
467a72a
Compare
ba81a0e
to
8dbe742
Compare
|
||
var sacQueryFilter *v1.Query | ||
if s.hasPermissionsChecker() { | ||
if ok, err := s.permissionChecker.GetAllowed(ctx); err != nil || !ok { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the current state of existing PermissionChecker
implementation, it does not make any difference, as these will check for global read access to the underlying resource(s).
Nevertheless, the generated store code was calling GetManyAllowed
on the permission checker.
@janisz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
467a72a
to
9bdc2c7
Compare
Graphite rebased this pull request as part of a merge. |
8dbe742
to
fb1f5d0
Compare
Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.