This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Remove MacOS keychain usage & prompts #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disable the obsolete swift code for reading unused core wallet password. * Disable spawning the portal log server.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running unsigned test builds of Blockstack.app, alarming keychain password prompts are shown several times. After talking with @jcnelson it looks like we aren't using any of that code anymore.
This PR:
I made as little changes as possible, not wanting to break anything. Essentially just commented out and short circuited a couple lines. There is probably more cleanup work that can be done here.