Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add principal generation to PropValue #325

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Conversation

Acaccia
Copy link
Collaborator

@Acaccia Acaccia commented Feb 6, 2024

This PR adds the possibility to generate principal type for PropValue. Accidentally, it can also generate lists with their entry type set to ListUnionType when we generate a list of qualified principals.

This PR fixes the usage of principal:

Fixes #305
Fixes #274

@Acaccia Acaccia self-assigned this Feb 6, 2024
csgui
csgui previously approved these changes Feb 6, 2024
Copy link
Collaborator

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (c1fc7b2) 91.47% compared to head (3f7bf59) 91.38%.

Files Patch % Lines
clar2wasm/src/lib.rs 6.66% 12 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   91.47%   91.38%   -0.10%     
==========================================
  Files          40       40              
  Lines       13788    13803      +15     
  Branches    13788    13803      +15     
==========================================
+ Hits        12613    12614       +1     
- Misses        546      558      +12     
- Partials      629      631       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Acaccia Acaccia added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit c0d3f3c Feb 6, 2024
6 of 7 checks passed
@Acaccia Acaccia deleted the feat/proptest-add-principal branch February 6, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A top level tuple triggers a panic Can't compile a clarity snippet with multiple principals
2 participants