Implement #1641 rpc call public functions as read-only #1992
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In starting to look into implementing #1981, I stumbled upon the implementation of
call-read
and thought maybe there was a way to call the same function in a read only fashion if it was madepublic
instead ofread-only
.And turns out, that the implementation was quite simple by changing a parameter and checking whether the code made any writes, and fail if it did.
#1981 still forthcoming.
Not consensus altering, so can be merged to master directly.