Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use bitcoin 25.0 for tests #4141

Merged
merged 2 commits into from
Dec 11, 2023
Merged

use bitcoin 25.0 for tests #4141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b04730
use bitcoin 25.0 for tests
wileyj Dec 8, 2023
2c501b7
Merge branch 'develop' into ci/fix-develop-tests
wileyj Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/atlas-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ jobs:
- name: Setup Test Environment
id: setup_tests
uses: stacks-network/actions/stacks-core/testenv@main

with:
btc-version: "25.0"

## Run test matrix using restored cache of archive file
## - Test will timeout after env.TEST_TIMEOUT minutes
- name: Run Tests
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/bitcoin-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
test-name:
- tests::bitcoin_regtest::bitcoind_integration_test
- tests::integrations::integration_test_get_info
- tests::neon_integrations::antientropy_integration_test ## forced failure
- tests::neon_integrations::antientropy_integration_test
- tests::neon_integrations::bad_microblock_pubkey
- tests::neon_integrations::bitcoind_forking_test
- tests::neon_integrations::bitcoind_integration_test
Expand Down Expand Up @@ -74,7 +74,9 @@ jobs:
- name: Setup Test Environment
id: setup_tests
uses: stacks-network/actions/stacks-core/testenv@main

with:
btc-version: "25.0"

## Run test matrix using restored cache of archive file
## - Test will timeout after env.TEST_TIMEOUT minutes
- name: Run Tests
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/create-cache.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:
uses: stacks-network/actions/stacks-core/cache/bitcoin@main
with:
action: save
btc-version: "25.0"

## Cache nextest archives for tests
nextest-archive:
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/epoch-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ jobs:
- name: Setup Test Environment
id: setup_tests
uses: stacks-network/actions/stacks-core/testenv@main

with:
btc-version: "25.0"

## Run test matrix using restored cache of archive file
## - Test will timeout after env.TEST_TIMEOUT minutes
- name: Run Tests
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/slow-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ jobs:
- name: Setup Test Environment
id: setup_tests
uses: stacks-network/actions/stacks-core/testenv@main

with:
btc-version: "25.0"

## Run test matrix using restored cache of archive file
## - Test will timeout after env.TEST_TIMEOUT minutes
- name: Run Tests
Expand Down
43 changes: 33 additions & 10 deletions .github/workflows/stacks-core-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
uses: stacks-network/actions/stacks-core/testenv@main
with:
genesis: true
btc-version: "25.0"

## Run test matrix using restored cache of archive file
## - Test will timeout after env.TEST_TIMEOUT minutes
Expand Down Expand Up @@ -84,7 +85,9 @@ jobs:
- name: Setup Test Environment
id: setup_tests
uses: stacks-network/actions/stacks-core/testenv@main

with:
btc-version: "25.0"

## Run test matrix using restored cache of archive file
## - Test will timeout after env.TEST_TIMEOUT minutes
- name: Run Tests
Expand Down Expand Up @@ -135,25 +138,45 @@ jobs:
# Core contract tests
core-contracts-clarinet-test:
name: Core Contracts Test
defaults:
run:
working-directory: "./contrib/core-contract-tests/"
runs-on: ubuntu-latest
steps:
## Checkout the code
- name: Checkout the latest code
id: git_checkout
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

## Use Clarinet to run contract unit-tests and create code coverage file
- name: Execute core contract unit tests in Clarinet
uses: actions/checkout@v3
- name: Execute core contract unit tests with clarinet-sdk
id: clarinet_unit_test
uses: docker://hirosystems/clarinet:1.8.0
uses: actions/setup-node@v3
with:
args: test --coverage --manifest-path=./contrib/core-contract-tests/Clarinet.toml

node-version: 18.x
cache: "npm"
cache-dependency-path: "./contrib/core-contract-tests/package-lock.json"
- run: npm ci
- run: npm test
## Upload code coverage file
- name: Code Coverage
id: codecov
uses: stacks-network/actions/codecov@main
with:
test-name: ${{ matrix.test-name }}
upload-only: true
filename: ./coverage.lcov
filename: ./lcov.info

# Core contract tests on Clarinet v1
# Check for false positives/negatives
# https://github.com/stacks-network/stacks-blockchain/pull/4031#pullrequestreview-1713341208
core-contracts-clarinet-test-clarinet-v1:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! How is this different than core-contract-clarinet-test-clarinet above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i did the merge from master->develop last week, this was something that was removed that @hugocaillard had worked on.
the clarinet docker image is something we found will no longer work with the latest image, so work was done to use the clarinet sdk vs the docker image.

i envision this v1 test can be removed in time, but i felt it worthwhile to keep since it was there before the merge from master.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More context in the link in the comment above
#4031 (review)

name: Core Contracts Test Clarinet V1
runs-on: ubuntu-latest
steps:
- name: Checkout the latest code
id: git_checkout
uses: actions/checkout@v3
- name: Execute core contract unit tests in Clarinet
id: clarinet_unit_test_v1
uses: docker://hirosystems/clarinet:1.7.1
with:
args: test --manifest-path=./contrib/core-contract-tests/Clarinet.toml contrib/core-contract-tests/tests/bns/name_register_test.ts