Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use bitcoin 25.0 for tests #4141

Merged
merged 2 commits into from Dec 11, 2023
Merged

use bitcoin 25.0 for tests #4141

merged 2 commits into from Dec 11, 2023

Conversation

wileyj
Copy link
Contributor

@wileyj wileyj commented Dec 8, 2023

Description

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@wileyj
Copy link
Contributor Author

wileyj commented Dec 8, 2023

relies on
#4136
#4139
#4140
#4142

@wileyj
Copy link
Contributor Author

wileyj commented Dec 10, 2023

develop changes (with the above 3 PR's merged) - all tests are passing:
https://github.com/wileyj/stacks-blockchain/actions/runs/7156082869

master is unaffected (due to calling composite workflows in develop with an additional btc-version arg. ex: https://github.com/stacks-network/stacks-core/blob/ci/fix-develop-tests/.github/workflows/atlas-tests.yml#L39-L40 ): https://github.com/wileyj/stacks-blockchain/actions/runs/7156079082

@wileyj wileyj marked this pull request as ready for review December 10, 2023 07:07
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7e9237) 72.02% compared to head (a7e9237) 72.02%.

❗ Current head a7e9237 differs from pull request most recent head 2c501b7. Consider uploading reports for the commit 2c501b7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4141   +/-   ##
========================================
  Coverage    72.02%   72.02%           
========================================
  Files          401      401           
  Lines       286385   286385           
========================================
  Hits        206256   206256           
  Misses       80129    80129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Core contract tests on Clarinet v1
# Check for false positives/negatives
# https://github.com/stacks-network/stacks-blockchain/pull/4031#pullrequestreview-1713341208
core-contracts-clarinet-test-clarinet-v1:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! How is this different than core-contract-clarinet-test-clarinet above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i did the merge from master->develop last week, this was something that was removed that @hugocaillard had worked on.
the clarinet docker image is something we found will no longer work with the latest image, so work was done to use the clarinet sdk vs the docker image.

i envision this v1 test can be removed in time, but i felt it worthwhile to keep since it was there before the merge from master.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More context in the link in the comment above
#4031 (review)

@wileyj wileyj merged commit ad88424 into develop Dec 11, 2023
1 check passed
This was referenced Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants