New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use bitcoin 25.0 for tests #4141
Conversation
develop changes (with the above 3 PR's merged) - all tests are passing: master is unaffected (due to calling composite workflows in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4141 +/- ##
========================================
Coverage 72.02% 72.02%
========================================
Files 401 401
Lines 286385 286385
========================================
Hits 206256 206256
Misses 80129 80129 ☔ View full report in Codecov by Sentry. |
# Core contract tests on Clarinet v1 | ||
# Check for false positives/negatives | ||
# https://github.com/stacks-network/stacks-blockchain/pull/4031#pullrequestreview-1713341208 | ||
core-contracts-clarinet-test-clarinet-v1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! How is this different than core-contract-clarinet-test-clarinet
above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i did the merge from master->develop last week, this was something that was removed that @hugocaillard had worked on.
the clarinet docker image is something we found will no longer work with the latest
image, so work was done to use the clarinet sdk vs the docker image.
i envision this v1
test can be removed in time, but i felt it worthwhile to keep since it was there before the merge from master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More context in the link in the comment above
#4031 (review)
5b94e69
to
7b04730
Compare
Description
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml