Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add&fix Interval::Display, fix MidiSet offest, check MidiNote range #22

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add&fix Interval::Display, fix MidiSet offest, check MidiNote range #22

wants to merge 5 commits into from

Conversation

ImprovingRigmarole
Copy link

A few minimal changes :

  • the offset in MidiSet just didn't allow to store midi note 127 (the only victim there)
  • got a panic on tritone & b9 Display so added those
  • thought that having split on Midiset would be nice

@ImprovingRigmarole ImprovingRigmarole mentioned this pull request Jun 2, 2024
Open
@matthunz
Copy link
Collaborator

Looks great, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImprovingRigmarole @matthunz