This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Fixed the initialization of the request-trace-remover thread pool so … #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that it only is instantiated when the servlet is initialized. This fixes an issue that a request-trace-remover thread would leak when redeploying the servlet if it's not actually in use e.g. if the stagemonitor widget is disabled. Due to the servlet never actually being deployed in that case, the servlet's destroy() method would never be called therefore resulting in a thread to leak each redeployment. Also moved registeration of the servlet as a request trace reporter until it's actually initialized.
felixbarny
added a commit
that referenced
this pull request
Nov 23, 2015
Fixed the initialization of the request-trace-remover thread pool so …
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…that it only is instantiated when the servlet is initialized. This fixes an issue that a request-trace-remover thread would leak when redeploying the servlet if it's not actually in use e.g. if the stagemonitor widget is disabled. Due to the servlet never actually being deployed in that case, the servlet's destroy() method would never be called therefore resulting in a thread to leak each redeployment. Also moved registeration of the servlet as a request trace reporter until it's actually initialized.