This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Metrics tab and Alerting based on MetricNames #182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests removes the
old.style.metric.names
in favor of the key-value basedMetricNames
. The most notable change is in the alerting tab, where you can filter the metrics to check by the metric name and tags by selecting them in a autocomplete-enabled input.Breaking changes
mean > 100
to express "alert me if the mean is greater than 100ms" you would now set the threshold tomean <= 100
i.e. "alert me if the average is not faster than 100ms". This is more in line with the "assert
style" many developers are familiar with. Think ofassert mean <= 100
.