Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Metrics tab and Alerting based on MetricNames #182

Merged
merged 17 commits into from
Jul 15, 2016
Merged

Conversation

felixbarny
Copy link
Member

@felixbarny felixbarny commented Jul 15, 2016

This pull requests removes the old.style.metric.names in favor of the key-value based MetricNames. The most notable change is in the alerting tab, where you can filter the metrics to check by the metric name and tags by selecting them in a autocomplete-enabled input.

add-check-modal

Breaking changes

  • The widget metric tab plugins now also work with tags and not with regex anymore
  • All existing alerts won't work anymore. Remove them from your configuration to avoid mapping errors and recreate them via the UI.
  • The semantics of the operator is inverted. When you previously would add a threshold like mean > 100 to express "alert me if the mean is greater than 100ms" you would now set the threshold to mean <= 100 i.e. "alert me if the average is not faster than 100ms". This is more in line with the "assert style" many developers are familiar with. Think of assert mean <= 100.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 76.513% when pulling 0f5cfca on metrics-tab-2 into 83351d5 on master.

@felixbarny felixbarny merged commit 359620b into master Jul 15, 2016
@felixbarny felixbarny deleted the metrics-tab-2 branch April 23, 2017 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants