Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised from previous PR90: Add contains function to RowIndex #93

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

kodeschreiber
Copy link

  • Added a "contains" function to the RowIndex trait
  • Defined the contains funtion for &str and usize columns

- Added a "contains" function to the RowIndex trait
- Defined the contains funtion for &str and usize columns
Copy link
Member

@IvanUkhov IvanUkhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, to make it useful, you have to define Row::contains.

src/cursor.rs Outdated Show resolved Hide resolved
@kodeschreiber
Copy link
Author

I updated the doc-string to your suggestion, and added the contains function as a wrapper in the Row struct.

@IvanUkhov IvanUkhov merged commit 9b59622 into stainless-steel:main Apr 24, 2024
5 checks passed
@IvanUkhov
Copy link
Member

Thank you! I usually add people to the authors list. Do you have any name and optionally email that you would like to see there?

@kodeschreiber
Copy link
Author

I'm good with my username being put in the list. Otherwise, I'm fine with just contributing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants