Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow loadbalancer service external IP #275

Merged
merged 6 commits into from
Jan 8, 2024
Merged

Allow loadbalancer service external IP #275

merged 6 commits into from
Jan 8, 2024

Commits on Jan 7, 2024

  1. allow loadbalancer service external IP

    @YonatanRubin @d3adb5
    YonatanRubin authored and d3adb5 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    8ee36ab View commit details
    Browse the repository at this point in the history

  2. refactor: define service type outside conditionals 

    Define the type property of our Service spec outside the branches of
these conditional statements, as it should always honor the chart value.
    @d3adb5
    d3adb5 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    e90b5d3 View commit details
    Browse the repository at this point in the history

  3. fix: proxy cluster ip value for all service types 

    Proxy the chart value for the Service's clusterIP field for all service
types.
    @d3adb5
    d3adb5 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    ac230da View commit details
    Browse the repository at this point in the history

  4. refactor: remove empty conditional branch 

    Remove empty conditional branch from the Service template.
    @d3adb5
    d3adb5 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    7380d16 View commit details
    Browse the repository at this point in the history

  5. feat: warn the user of the deprecation of load-balancer-ip 

    Warn the chart's user of the deprecation of the Service loadBalacerIP
field since Kubernetes v1.24.
    @d3adb5
    d3adb5 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    5488bbc View commit details
    Browse the repository at this point in the history

  6. fix: address whitespace concerns in service metadata 

    Address whitespace concerns when rendering Service labels and
annotations.
    @d3adb5
    d3adb5 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    0bd9dab View commit details
    Browse the repository at this point in the history