Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JA Presamp Phonemizer] Some starting consonant fixes/adjustments #1150

Merged
merged 3 commits into from
Jun 9, 2024

Conversation

lottev1991
Copy link
Contributor

@lottev1991 lottev1991 commented May 19, 2024

This PR fixes 2 main things:

  • Starting consonants will no longer be inserted before syllables that start with a priority consonant. This is because most priority consonants (usually stops and affricates) are not configured in a way to handle this in Japanese voicebanks (if the end user wishes to include stop consonants anyway, e.g. when they're configured similarly to in Arpasing banks, simply remove them from under the [PRIORITY] line in the presamp.ini);
  • If a voice color does not contain a starting consonant in the oto, it will no longer be inserted (similar to how VC works). Now, it will insert a starting consonant from the main color if it exists, which may give undesired results.
  • Adjust VC and starting C length based on tempo changes, similar to ZH CVVC: Fix note timing after tempo change #1161. I'm gonna look into turning this into the default behavior (though I will keep the old method for legacy functionality).

@maiko3tattun
Copy link
Contributor

Thinking about starting consonant again, since there are only consonants, there is not much difference between each voice color, and it would be acceptable to fall back on the main?

@lottev1991
Copy link
Contributor Author

Not necessarily. For example, I have a voicebank with a devoiced/whisper voice color, and one with a death growl voice color. Both are special voice types and CV-only; using starting C with them would sound odd. That's why I decided on this change.

@stakira stakira merged commit 1e617aa into stakira:master Jun 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants