Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH action for releasing with BigWigsMods/packager #68

Merged
merged 1 commit into from Oct 31, 2022

Conversation

MyGamesDevelopmentAcc
Copy link
Contributor

Can you please merge this PR @jturel and tag it with the version 3.2.0? This will allow this addon to be picked up by wowup client.

@jturel
Copy link
Collaborator

jturel commented Oct 31, 2022

@MyGamesDevelopmentAcc seems cool! i'll need to learn more about wowup and https://github.com/BigWigsMods/packager - will take a look tonight

Copy link
Collaborator

@jturel jturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still learning about the mod release process.

It would (imo) be best to continue releasing this mod under the existing listing on Curseforge which means we'd need an API token here specified as CF_API_KEY. Maybe @stako can add one to this repo for us that we can read from the secrets since they control the CF project.

https://github.com/BigWigsMods/packager#uploading

# we first have to clone the AddOn project, this is a required step
- name: Clone project
uses: actions/checkout@v3

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a step here to remove the stuff from the repo that we don't want to get packaged up with the mod? Those files would be: .github/ and .luacheckrc - not that they are sensitive data, but they're not relevant to the player

Something like:

- name: delete non-release files
- run: rm -rf .github/ .luacheckrc

It looks like this would also be achievable by adding a .pkgmeta file to the repo per https://github.com/BigWigsMods/packager/wiki/Preparing-the-PackageMeta-File#changing-the-package-name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look here: https://github.com/MyGamesDevelopmentAcc/sArena/releases/tag/testrelease_1
Those files do not land in the release already.

For curse to work it would require just adding the curse key by @stako .

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look here: https://github.com/MyGamesDevelopmentAcc/sArena/releases/tag/testrelease_1 Those files do not land in the release already.

Nice. Don't hesitate to share that kind of context (link to test release) in the PR description :)

For curse to work it would require just adding the curse key by @stako .

@jturel jturel changed the title Add releasing Add GH action for releasing with BigWigsMods/packager Oct 31, 2022
@jturel jturel merged commit 1542cd6 into stako:master Oct 31, 2022
@jturel
Copy link
Collaborator

jturel commented Oct 31, 2022

@MyGamesDevelopmentAcc https://github.com/stako/sArena/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants