Skip to content
This repository has been archived by the owner on Oct 26, 2021. It is now read-only.

WIP: Add link to documentation #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ichpuchtli
Copy link

Just a starting point. Might look better with the link under sandbox. Note cannot click on link at the moment as elevation2before and elevation2after blocking click event somehow.
image

…r the

operator label. Note cannot click on link at the moment as elevation2before and elevation2after blocking click event somehow.
@toolness
Copy link

toolness commented Apr 5, 2016

Ah, I was about to file an issue about this--as a beginner to RxJS, I would find this really helpful. Thanks for working on it @ichpuchtli!

@toolness toolness mentioned this pull request Apr 5, 2016
@jmfayard
Copy link

jmfayard commented Sep 28, 2016

People looking at rxmarbles do not come from RxJs only but all kind of languages.
It might make sense to link to the reactivex.io website instead
e.g: http://reactivex.io/documentation/operators/debounce.html

marginTop: '5px'
};
let operatorName = label.split('(')[0].toLowerCase();
let href = `https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/core/operators/${operatorName}.md`;
Copy link

@Kisty Kisty Sep 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would broaden the documentation to other languages. Also, there's information and links to different languages. e.g. http://reactivex.io/documentation/operators/debounce.html

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to all the operators map to reactivex.io. Maybe an effort could be made to duplicated this for xstream and rxjs5.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, don't all operators map to the generic documentation?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants