Fix some lint issues and update airbnb #236
Conversation
| for (let i = 0; i < keys.length; i++) { | ||
| const key = keys[i]; | ||
|
|
||
| return Object.keys(src).reduce((result, key) => { |
There was a problem hiding this comment.
This for loop was a performance optimization.
The problem with reduce is the performance. We are creating one more object (function) and scope. Accessing variables of the upper scope is slower than accessing from own scope.
More info here: https://github.com/petkaantonov/bluebird/wiki/Optimization-killers
Please, revert the loop (and the other one). Stampit has to be fast!
There was a problem hiding this comment.
Sorry. That's the right link: https://reaktor.com/blog/javascript-performance-fundamentals-make-bluebird-fast/
There was a problem hiding this comment.
Sorry, but performance is relative till you introduce actual performance tests. I would prefer clarity of code till we know this is a bottleneck...
There was a problem hiding this comment.
Isn't that statement applicable for apps and not libraries? 😏
danielkcz
force-pushed
the
v3_0-linting-fixes
branch
from
c73112f
to
ade2144
Compare
danielkcz
force-pushed
the
v3_0-linting-fixes
branch
from
ade2144
to
777988f
Compare
I've replaced for loops using
++operator withreducewhich I would say is better in general.Change for a rule "no-use-before-define" allows hoisting of functions which is necessary to pass with green lights :)
Updated airbnb since it was complaining about new version of eslint. Nothing for broken because of that.