Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some lint issues and update airbnb #236

Merged
merged 1 commit into from
Sep 22, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"comma-dangle": 0,
"no-confusing-arrow": 0,
"prefer-rest-params": 0,
"no-use-before-define": 1,
"no-plusplus": ["error", { "allowForLoopAfterthoughts": true }]
"no-use-before-define": [2, "nofunc"],
}
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"check-compose": "^3.2.0",
"dependency-check": "^2.5.0",
"eslint": "^3.5.0",
"eslint-config-airbnb-base": "^7.1.0",
"eslint-config-airbnb-base": "7.1.0",
"eslint-plugin-import": "^1.15.0",
"isparta": "^4.0.0",
"lodash": "^4.16.1",
Expand Down
2 changes: 1 addition & 1 deletion src/extract-functions.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import isFunction from './isFunction';

export default function (...args) {
let result = [];
for (let i = 0; i < args.length; i++) {
for (let i = 0; i < args.length; i += 1) {
const arg = args[i];
if (isFunction(arg)) result.push(arg);
else if (Array.isArray(arg)) result = result.concat(arg.filter(isFunction));
Expand Down
2 changes: 1 addition & 1 deletion src/merge.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function mergeOne(dst, src) {
const returnValue = isObject(dst) ? dst : {};

const keys = Object.keys(src);
for (let i = 0; i < keys.length; i++) {
for (let i = 0; i < keys.length; i += 1) {
const key = keys[i];

const srcValue = src[key];
Expand Down