Refs and props #60
Merged
Refs and props #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| function cloneAndExtend(fixed, extensionFunction, args) { | ||
| args = arguments.length > 3 ? slice(arguments, 2, arguments.length) : args; | ||
| var stamp = stampit(fixed.methods, fixed.state, fixed.enclose); | ||
| var stamp = stampit(fixed.methods, fixed.refs, fixed.enclose, fixed.props); |
There was a problem hiding this comment.
Shouldn't we also support composing with legacy stamps that have fixed.state?
There was a problem hiding this comment.
Let me add a unit test on that. It's better to be as backwards compatible as possible.
|
I've just addressed the stampit@1.1 compatibility. See the PR please. |
| @@ -3909,8 +3933,9 @@ function isStamp(obj) { | |||
| return ( | |||
There was a problem hiding this comment.
This will return false for legacy stamps.
This was referenced May 20, 2015
Merged
|
Fixed the mentioned issues. Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
staterenamed torefs. New aliasedfixed.stateandstate()were added forstamp.fixed.refsandstamp.refs().Added
stamp.fixed.props,stamp.props()and fourth parameter to thestampit()function.