-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divergences for mcmc_scatter #112
Conversation
(Running R CMD CHECK now, will report back with the results) |
[ci skip]
Passes R CMD CHECK |
[ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. We'll probably need a vignette to show off all these _np
functions.
Cool. I just added a quick example of using |
This PR adds an
np
andnp_style
arguments tomcmc_scatter
so that divergences can be highlighted in the plot. It also adds thescatter_style_np
function to use when specifyingnp_style
.(It's a little bit annoying to have a bunch of functions (e.g.
scatter_style_np
,pairs_style_np
,trace_style_np
,parcoord_style_np
) that are used to specify thenp_style
argument depending on the plotting function. It would be nice just to have one function for that, but I tried playing around with that and it's even more annoying because it makes it more confusing to have different defaults for the shape, style, alpha, arguments depending on the plotting function. With different functions the default values can be made more explicit.)Example usage