Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extractor methods for CmdStanMCMC objects (from CmdStanR) #227

Merged
merged 4 commits into from
Aug 7, 2020

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Jun 20, 2020

Adds extractor functions (nuts_params, neff_ratio, etc.) for models fit using CmdStanR. Also added tests, but they are skipped on CRAN and if CmdStanR is not installed.

@jgabry jgabry added the feature label Jun 20, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2020

Codecov Report

Merging #227 into master will decrease coverage by 0.70%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   99.28%   98.58%   -0.71%     
==========================================
  Files          31       31              
  Lines        3927     3958      +31     
==========================================
+ Hits         3899     3902       +3     
- Misses         28       56      +28     
Impacted Files Coverage Δ
R/bayesplot-extractors.R 69.47% <12.50%> (-28.99%) ⬇️
R/mcmc-diagnostics-nuts.R 100.00% <100.00%> (ø)
R/mcmc-intervals.R 99.20% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ee4dd...376accc. Read the comment docs.

@jgabry jgabry requested a review from tjmahr August 6, 2020 23:34
Copy link
Collaborator

@tjmahr tjmahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine. But do update NEWS.md

@jgabry
Copy link
Member Author

jgabry commented Aug 7, 2020

Thanks, yeah I forgot to update NEWS. Just added a news entry.

@tjmahr tjmahr merged commit e54367b into master Aug 7, 2020
@tjmahr tjmahr deleted the cmdstanr-support branch August 7, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants