-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verbose mode and replace regexpr #392
Conversation
Nice, thanks! This looks great except that the uses of |
@@ -14,6 +14,10 @@ os_is_macos <- function() { | |||
isTRUE(Sys.info()[["sysname"]] == "Darwin") | |||
} | |||
|
|||
is_verbose_mode <- function() { | |||
getOption("cmdstanr_verbose", default = FALSE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way you had this function was totally fine, but to simplify things I changed it to use getOption()
, which conveniently handles the NULL
case with the default
argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah didnt know that. Thanks!
Ok I changed |
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
==========================================
- Coverage 88.20% 88.05% -0.16%
==========================================
Files 12 12
Lines 2713 2720 +7
==========================================
+ Hits 2393 2395 +2
- Misses 320 325 +5
Continue to review full report at Codecov.
|
Maybe we add it to the internals vignette? Do we want to do it here or add to the vignette list? |
Sounds good. Either way is fine by me. |
Will add it here tomorrow and then merge. |
Ok cool, thanks! |
@jgabry I updated the vignette, check whenever you have a few moments. |
Looks great! I'm going to quickly add an example to the section you created so people can see what the verbose mode output looks like and then I'll merge this. |
Summary
Fixes #385
Fixes #391
I was in a slam dunk issue squashing mood so decided to squash these two.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: