Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable jacobian argument for optimization #799

Merged
merged 5 commits into from
Jul 30, 2023
Merged

enable jacobian argument for optimization #799

merged 5 commits into from
Jul 30, 2023

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Jul 29, 2023

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Adds jacobian argument to optimize method.
Closes #761 and paves the way for #760 (adding Laplace sample)

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@jgabry jgabry requested a review from rok-cesnovar July 29, 2023 18:06
@jgabry jgabry requested a review from andrjohns July 29, 2023 21:07
@jgabry
Copy link
Member Author

jgabry commented Jul 29, 2023

I think this is ready for review. I put both @rok-cesnovar and @andrjohns as reviewers but this probably only needs one of you, it's not too complicated.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2023

Codecov Report

Merging #799 (37878f5) into master (407db8c) will decrease coverage by 0.03%.
The diff coverage is 90.00%.

❗ Current head 37878f5 differs from pull request most recent head b47a327. Consider uploading reports for the commit b47a327 to get more accurate results

@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
- Coverage   88.27%   88.24%   -0.03%     
==========================================
  Files          12       12              
  Lines        4152     4160       +8     
==========================================
+ Hits         3665     3671       +6     
- Misses        487      489       +2     
Files Changed Coverage Δ
R/args.R 97.76% <88.88%> (-0.16%) ⬇️
R/model.R 90.59% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jgabry
Copy link
Member Author

jgabry commented Jul 29, 2023

I'll work on #760 next

@jgabry jgabry mentioned this pull request Jul 30, 2023
2 tasks
Copy link
Collaborator

@andrjohns andrjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jgabry
Copy link
Member Author

jgabry commented Jul 30, 2023

LGTM, thanks!

Thanks for reviewing. Will merge now and continue working on the Laplace method in #800

@jgabry jgabry merged commit e8fc2d3 into master Jul 30, 2023
12 checks passed
@jgabry jgabry deleted the jacobian-argument branch July 30, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable jacobian flag for optimize
3 participants