Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation schedule for minor (breaking) language changes #43

Merged
merged 6 commits into from
Nov 11, 2021

Conversation

WardBrian
Copy link
Member

@WardBrian WardBrian commented Sep 27, 2021

Copy link
Collaborator

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main contentful comment here is that we should commit to 3 minor releases or 1 major release for minor deprecations. We should also say anything that's not a minor deprecation as defined here will require a major version bump.

I hope you appreciate the more nitpicky comments rather than finding them annoying.

designs/0031-deprecation-schedule.md Outdated Show resolved Hide resolved
designs/0031-deprecation-schedule.md Outdated Show resolved Hide resolved
designs/0031-deprecation-schedule.md Outdated Show resolved Hide resolved
designs/0031-deprecation-schedule.md Outdated Show resolved Hide resolved
designs/0031-deprecation-schedule.md Outdated Show resolved Hide resolved
designs/0031-deprecation-schedule.md Outdated Show resolved Hide resolved
designs/0031-deprecation-schedule.md Outdated Show resolved Hide resolved
designs/0031-deprecation-schedule.md Outdated Show resolved Hide resolved
designs/0031-deprecation-schedule.md Outdated Show resolved Hide resolved
designs/0031-deprecation-schedule.md Outdated Show resolved Hide resolved
@WardBrian WardBrian changed the title Deprecation schedule for minor breaking changes Deprecation schedule for minor (breaking) language changes Sep 27, 2021
@WardBrian
Copy link
Member Author

I'd like to ask for any more feedback on this. We will be discussing it during Thursday's language meeting and then merging unless there are objections

@rok-cesnovar rok-cesnovar self-requested a review November 9, 2021 19:25
Copy link
Collaborator

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants