Avoid R cmd check NOTEs about some internal functions #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rbind in base R has different arguments than the method defined here. But we don't need to make an S3 method for rbind, we can just use a regular function * need to register all S3 methods even if generic is not exported * I also converted some function names that start with `.` to be consistent with other package code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered these when checking using CRAN's win-builder service: https://win-builder.r-project.org/r47PXKC5r0Wa/00check.log
rbind in base R has different arguments than the rbind method defined in loo_subsample.R. But we don't need to make an S3 method for rbind, we can just use a regular function
need to register all S3 methods even if generic is not exported