Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid R cmd check NOTEs about some internal functions #240

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Avoid R cmd check NOTEs about some internal functions #240

merged 1 commit into from
Feb 2, 2024

Commits on Feb 1, 2024

  1. avoid R cmd check NOTEs about some internal functions 

    * rbind in base R has different arguments than the method defined here. But we don't need to make an S3 method for rbind, we can just use a regular function

* need to register all S3 methods even if generic is not exported

* I also converted some function names that start with `.` to be consistent with other package code.
    @jgabry
    jgabry committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    78201db View commit details
    Browse the repository at this point in the history