-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 2682 operands and partials 8 #2833
Feature/issue 2682 operands and partials 8 #2833
Conversation
Hi @Franzi2114 I think on my home computer I have a version of |
Hey @SteveBronder, extending operands_and_partials to infinitely many inputs sounds much better than just expanding it to 8. Since I need this for my PR #2822, it would be nice to have it as soon as possible. But Thursday is totally fine for me. Your implementation should work with the call in our new So, shall I close this PR then? Or does somebody else do it? Should we refer to your PR in a few days? |
Yes
Yep!
No if I don't have time to do update the variadic PR or if something bonks in it then we can go with this version. |
@Franzi2114 see the PR below, apologies for the delay. It's a bit of a big PR so it might take till after this coming release for someone to review and merge |
Hi @SteveBronder, what do you think: Will your PR #2841 be finished in the near future so that I can use the functionality for the 7-parameter DDM (PR #2822) or could we prioritize this PR #2833 such that the PR #2822 can move forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Franzi2114! I'll approve and merge this so it's compatible with your other changes
This refers to issue #2698. I just closed that issue. |
Summary
Here, we adapt the operands_and_partials routine such that it works for 8 parameters. We need this feature for issue #2682. This is a split from PR #2822.
We adapted the following files:
-stan/math/prim/functor/operands_and_partials.hpp
-stan/math/rev/functor/operands_and_partials.hpp
-stan/math/fwd/functor/operands_and_partials.hpp
-stan/math/opencl/rev/operands_and_partials.hpp
-test/unit/math/prim/functor/operands_and_partials_test.cpp
-test/unit/math/rev/functor/operands_and_partials_test.cpp
Tests
We also adapted the test files:
-test/unit/math/prim/functor/operands_and_partials_test.cpp
-test/unit/math/rev/functor/operands_and_partials_test.cpp
Side Effects
No.
Release notes
operands_and_partials expanded to accept 8 parameters.
Checklist
Math issue Adding 7-Parameter Drift Diffusion Model (DDM) PDF with partial derivatives to Stan Math #2682
Copyright holder: (fill in copyright holder information)
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
[x]the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested