Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v4.8.1 #3011

Merged
merged 8 commits into from
Jan 25, 2024
Merged

Release/v4.8.1 #3011

merged 8 commits into from
Jan 25, 2024

Conversation

serban-nicusor-toptal
Copy link
Contributor

Summary

Merge release v4.8.1 into develop

Tests

Side Effects

Are there any side effects that we should be aware of?

Release notes

Checklist

  • Copyright holder: (fill in copyright holder information)

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@WardBrian
Copy link
Member

This is hitting some weird build error in the MPI tests. Any ideas @serban-nicusor-toptal?

@serban-nicusor-toptal
Copy link
Contributor Author

I'm not entirely sure, maybe it comes from the PRs merged. I triggered a re-run just to be sure it's not a one-off error.

@WardBrian
Copy link
Member

@rok-cesnovar any ideas why we'd be having test problems here? The only changes in this branch already passed ci in #3002: https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FMath/detail/PR-3002/16/pipeline

@WardBrian WardBrian merged commit f834833 into develop Jan 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants