-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix variance() in summarise_draws() #221
Conversation
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
=======================================
Coverage 94.32% 94.33%
=======================================
Files 41 41
Lines 2872 2875 +3
=======================================
+ Hits 2709 2712 +3
Misses 163 163
Continue to review full report at Codecov.
|
|
I am happy with the PR from my side. After you have merged this, I will prepare a new release of posterior to CRAN. |
Sounds good, thanks all! I fixed a minor test case failure on R < 4 and am merging now (the failure of macOS devel on github ci is spurious). |
Today I submitted the new version of posterior to CRAN and it should be released in a few days. |
Summary
This PR is mainly to fix #219 by adding a
variance.draws_array()
andvariance.draws_matrix()
implementation so thatvariance()
works properly withsummarise_draws()
. For example this works correctly (and should continue to do so on future versions of {distributional}):There are two other minor fixes I made while I was in here:
rvar
to character vectors viavec_cast(x, character())
oras.character(x)
. This is mainly so that functions likepaste()
work as expected when passedrvar
s; e.g. this now works:skip_if_not_installed("caret")
to all tests ofrstar()
since that function requires {caret}, but {caret} is only in "Suggests".Since these are all minor changes, once tests / coverage passes if I don't hear any objections in the next week or so I'll merge.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: