Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch stanfunctions support for future versions of Stanc3 #103

Merged
merged 1 commit into from Mar 9, 2023
Merged

Patch stanfunctions support for future versions of Stanc3 #103

merged 1 commit into from Mar 9, 2023

Conversation

andrjohns
Copy link
Collaborator

This PR updates the compatibility of exporting standalone functions for more recent versions of stanc3 (i.e., the experimental rstan, or custom versions with the latest stanc3).

There are three main behaviours patched:

  • Recent stanc3 will emit standalone function plain types using a forward declaration, whereas older versions using a functor within a struct
  • Default template parameters under stanc3 2.31 cause a compiler error under clang (they use 0 instead of nullptr)
  • There is no longer a stan/math/prim/mat/fun/Eigen.hpp file

@jgabry
Copy link
Member

jgabry commented Mar 9, 2023

Great, thanks!

@jgabry jgabry merged commit 0ae1349 into stan-dev:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants