Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in multi_normal distribution & others #299

Closed
4 tasks done
syclik opened this issue Oct 21, 2013 · 1 comment
Closed
4 tasks done

Bug in multi_normal distribution & others #299

syclik opened this issue Oct 21, 2013 · 1 comment
Milestone
v2.0.1

Comments

@syclik
Copy link
Member

syclik commented Oct 21, 2013

We have a bug in the calculation of the multi_normal distribution. This was ok in v1.3.0, but not in v2.0.0.

There currently aren't enough unit tests to catch it, so that should come first.

  • unit test multi_normal distribution
  • unit test multi_normal_prec
  • unit test multi_normal_cholesky
  • fix multi_normal distribution code
bob-carpenter pushed a commit that referenced this issue Oct 22, 2013
fixed multi_normal ONLY ONE FUNCTION SIGNATURE; fixes half of #299
8ed83cd
bob-carpenter pushed a commit that referenced this issue Oct 22, 2013
fixed multi_normal tests ONLY ONE FUNCTION SIGNATURE; fixes OTHER hal…
72193e6 
…f of #299
@bob-carpenter
Copy link
Contributor

Only the basic multi_normal had an issue in 2.0. Everything else passed the new gradient tests as it was in 2.0. Which is good.

bob-carpenter pushed a commit that referenced this issue Oct 23, 2013
finishes fix for issue #299 -- unit tests for gradients of multi_normal
a8aa2c3
syclik added a commit that referenced this issue Oct 24, 2013
@syclik
Merge pull request #308 from stan-dev/feature/issue-299-fix-multinormal
0e3fc8c 
Fixes #299
@syclik syclik closed this as completed Oct 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.1
Development

No branches or pull requests
2 participants
@syclik @bob-carpenter