Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_prob() function to replace lp__ #470

Closed
bob-carpenter opened this issue Dec 28, 2013 · 1 comment
Closed

log_prob() function to replace lp__ #470

bob-carpenter opened this issue Dec 28, 2013 · 1 comment
Assignees
@bob-carpenter
Labels
feature language
Milestone
v2.5.0

Comments

@bob-carpenter
Copy link
Contributor

Because direct access of lp__ is deprecated, we should have a log_prob() function that returns the value of lp__ at the point it is evaluated.
@ghost ghost assigned bob-carpenter Dec 28, 2013
@syclik syclik modified the milestones: v2.3.0++, v2.3.0 May 15, 2014
@bob-carpenter bob-carpenter modified the milestones: v2.4.0++, v2.4.0 Jul 7, 2014
@bob-carpenter
Copy link
Contributor Author

Have to be careful here to print the sum of the accumulator plus lp__.

  • just implement as accumulator sum + lp__ using the lp suffix code generation and testing for context in place
  • unit tests
  • doc, including recommendation to diagnose where log probs go wrong
  • change name to get_lp to leverage the lp suffix

bob-carpenter pushed a commit that referenced this issue Aug 16, 2014
fix issue #470, add get_lp function
525edd4
@syclik syclik closed this as completed in 8e87704 Aug 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bob-carpenter bob-carpenter

Labels
feature language
Projects
None yet
Milestone
v2.5.0
Development

No branches or pull requests
3 participants
@syclik @bob-carpenter @mitzimorris