Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize OperandsAndPartials #676

Closed
13 tasks done
PeterLi2016 opened this issue Jun 3, 2014 · 1 comment
Closed
13 tasks done

Generalize OperandsAndPartials #676

PeterLi2016 opened this issue Jun 3, 2014 · 1 comment

Comments

@PeterLi2016
Copy link
Contributor

Generalize OperandsAndPartials so it works for probability distributions with forward mode and reverse mode auto-diff.

Distribution Test fixtures:

  • Update test_fixture_distr
  • Update test_fixture_cdf
  • Update test_fixture_cdf_log
  • Update test_fixture_ccdf_log

New tests to add:

  • add higher order diff tests for inc_beta [no need to do grad_inc_beta since we're testing this already here]
  • add higher order diff tests for grad_reg_inc_beta
  • add higher order diff tests for F32
  • add higher order diff tests for grad_F32
  • add higher order diff tests for grad_2F1
  • add higher order diff tests for grad_reg_inc_gamma

Other:

  • rename DoubleVectorView to VectorBuilder
  • fix make file for clean-all (issue make clean-all Error 126 #697)
  • change algorithm for generating test cases so doubles are not repeated
@PeterLi2016 PeterLi2016 added this to the v2.3.0++ milestone Jun 3, 2014
@PeterLi2016 PeterLi2016 self-assigned this Jun 3, 2014
@PeterLi2016
Copy link
Contributor Author

Everything is in this branch: https://github.com/stan-dev/stan/tree/feature/issue-676-generalize-operandsandpartials.

I think I've got OperandsAndPartials generalized and working with the prob functions (I've only fixed normal_log so far). So how do we want go about testing? I'd imagine we want to follow something similar to what Daniel already has implemented for the rev probability functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants