Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stan::common::do_bfgs_optimize allows interruption #768

Closed
maverickg opened this issue Jul 13, 2014 · 2 comments
Closed

stan::common::do_bfgs_optimize allows interruption #768

maverickg opened this issue Jul 13, 2014 · 2 comments
Assignees
Milestone

Comments

@maverickg
Copy link
Contributor

I am not sure if there is alway an issue for this one. Now the loop in the API, rstan cannot check if there is an interruption from the user (such as a Ctrl+C).

@bob-carpenter
Copy link
Contributor

Glad you're keeping an eye on this, as it's
an important point.

The only solution I see if the interrupts are
interface or platform specific is to provide callbacks
inside our algorithms for interrupters. I'm not
exactly sure how that would work. But I'd like to make
it a reasonably high priority because it's incredibly
frustrating to have to hard kill a process because it's
running something uninterruptible.

  • Bob

On Jul 12, 2014, at 9:34 PM, maverickg notifications@github.com wrote:

I am not sure if there is alway an issue for this one. Now the loop in the API, rstan cannot check if there is an interruption from the user (such as a Ctrl+C).


Reply to this email directly or view it on GitHub.

@syclik
Copy link
Member

syclik commented Jul 13, 2014

Yes, thanks Jiqiang for spotting this!

Bob, I have a callback for the sampling, so the mechanism is already built.
I had to do it as part of the initial refactor.

I think we're close to sitting down and designing something that will be
sustainable moving forward.

On Jul 13, 2014 12:20 AM, "Bob Carpenter" notifications@github.com wrote:

Glad you're keeping an eye on this, as it's
an important point.

The only solution I see if the interrupts are
interface or platform specific is to provide callbacks
inside our algorithms for interrupters. I'm not
exactly sure how that would work. But I'd like to make
it a reasonably high priority because it's incredibly
frustrating to have to hard kill a process because it's
running something uninterruptible.

  • Bob

On Jul 12, 2014, at 9:34 PM, maverickg notifications@github.com wrote:

I am not sure if there is alway an issue for this one. Now the loop in
the API, rstan cannot check if there is an interruption from the user (such
as a Ctrl+C).


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#768 (comment).

@syclik syclik self-assigned this Aug 9, 2014
@syclik syclik added this to the v2.4.0++ milestone Aug 9, 2014
@syclik syclik closed this as completed in 3c0cf62 Aug 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants