Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 1060 build issues #1061

Merged
merged 3 commits into from
Oct 2, 2014
Merged

Conversation

syclik
Copy link
Member

@syclik syclik commented Oct 1, 2014

Summary:

Adds additional dependencies for bin/libstan.a and bin/libstanc.a so they will automatically be rebuilt when header files change.

Intended Effect:

See summary. These targets didn't have dependencies on their respective header files (.hpp) which prevented them from being rebuilt automatically.

How to Verify:

  1. Run a test, for example, > ./runTests.py src/test/unit/gm/parser/get_lp_test.cpp
  2. Change the time-stamp on a header file needed for either libstan.a or libstanc.a. For example, > touch src/stan/gm/grammars/whitespace_grammar.hpp.
  3. Run the test again.

Under the develop branch, the library files aren't rebuilt. With this fix, the library files should rebuild automatically.

Side Effects:

Added a clean-deps target and removed the clean-models target. If tests stop compiling, running make clean-deps should put everything back into the right state.

Documentation:

The makefile documents clean-deps. No other doc needed.

Reviewer Suggestions:

Anyone.

@stan-buildbot
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://d1m1s1b1.stat.columbia.edu:8080/job/Stan%20Pull%20Request/14/Test PASSed.

syclik added a commit that referenced this pull request Oct 2, 2014
@syclik syclik merged commit 0273e59 into develop Oct 2, 2014
@syclik syclik deleted the feature/issue-1060-build-issues branch October 2, 2014 02:50
@syclik syclik modified the milestone: v2.5.0++ Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants