Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1946 double warnings #2027

Merged
merged 3 commits into from Aug 27, 2016
Merged

Bugfix/1946 double warnings #2027

merged 3 commits into from Aug 27, 2016

Conversation

bob-carpenter
Copy link
Contributor

Submisison Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Remove duplicate warnings in expressions.

Intended Effect

See summary.

How to Verify

Unit test from @ariddell's issue.

Side Effects

No.

Documentation

n/a

Reviewer Suggestions

Anyone.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@bob-carpenter
Copy link
Contributor Author

bob-carpenter commented Aug 24, 2016

Not sure what's up. I think I branched this from the other pending pull request's branch, feature/1940-prob-syntax-warn --- not sure why it wants to merge it into develop

@bob-carpenter
Copy link
Contributor Author

This looks like another Travis failure. @syclik --- could you confirm?

@bob-carpenter
Copy link
Contributor Author

@syclik Could you re-kick-off the Travis job? I don't seem to have permissions. Or wait until others have finished. Somehow my latest pull request got through Travis first, so they must not be going in order of being called or must have wildly different execution speeds.

@syclik syclik merged commit 2550aa6 into develop Aug 27, 2016
@syclik syclik deleted the bugfix/1946-double-warnings branch August 27, 2016 04:23
@syclik syclik modified the milestone: v2.12.0 Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants